From 4995a08260269aa1bf742ff81e8d75a88d410965 Mon Sep 17 00:00:00 2001
From: mxmlndml <42516330+mxmlndml@users.noreply.github.com>
Date: Mon, 28 Aug 2023 20:17:42 +0200
Subject: [PATCH] detect dns records to patch properly

---
 src/index.ts | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/index.ts b/src/index.ts
index cfc1682..3c8b3a7 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -2,7 +2,8 @@ import { getDnsRecords, patchDnsRecords } from "./cloudflare";
 import getPublicIp from "./getPublicIp";
 import * as log from "./log";
 
-const { ZONE_ID, DOMAIN_NAMES, API_KEY, INTERVAL } = process.env;
+const { ZONE_ID, DOMAIN_NAMES, API_KEY } = process.env;
+const INTERVAL = process.env.INTERVAL ?? "5";
 
 if (ZONE_ID === undefined) {
   log.error("could not access environment variable 'ZONE_ID'");
@@ -27,9 +28,9 @@ const dynamicDns = async () => {
       getDnsRecords(ZONE_ID, domainNames, "A", API_KEY),
     ]);
 
-    const dnsRecordsToPatch = dnsRecords.filter((dnsRecord) => {
-      dnsRecord.content !== publicIp;
-    });
+    const dnsRecordsToPatch = dnsRecords.filter((dnsRecord) =>
+      dnsRecord.content !== publicIp
+    );
 
     if (dnsRecordsToPatch.length === 0) {
       log.info(`public ip address remained at '${publicIp}', no patch needed`);
@@ -60,5 +61,5 @@ const dynamicDns = async () => {
 dynamicDns();
 setInterval(
   dynamicDns,
-  Number.parseInt(INTERVAL === undefined ? "5" : INTERVAL) * 60 * 1000,
+  Number.parseInt(INTERVAL) * 60 * 1000,
 );